Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-experimental] Add support for pep 3134, attach cause of exception #6388

Merged
merged 14 commits into from
May 22, 2020

Conversation

sebastien-rosset
Copy link
Contributor

@sebastien-rosset sebastien-rosset commented May 21, 2020

Using the exception chaining model as specified in pep 3134. It's really useful for troubleshooting issues.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link

auto-labeler bot commented May 21, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@sebastien-rosset
Copy link
Contributor Author

Just realized this does not work for python2 unfortunately.

@sebastien-rosset sebastien-rosset marked this pull request as ready for review May 22, 2020 05:13
@sebastien-rosset
Copy link
Contributor Author

@spacether

@spacether spacether added this to the 5.0.0 milestone May 22, 2020
Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for the PR!

@spacether spacether merged commit 19e1423 into OpenAPITools:master May 22, 2020
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request May 23, 2020
* master:
  [samples] Regenerate python-experimental
  [core][general] Add metadata file tracking to aid in "Golden Tests" regeneration (OpenAPITools#6325)
  [python-experimental] Add support for pep 3134, attach cause of exception (OpenAPITools#6388)
  [Java-jersey2] Add new ApiClient constructor with auth objects (OpenAPITools#6393)
@sebastien-rosset sebastien-rosset deleted the python-pep-3134 branch May 23, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants