Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Client: Allow dot in path parameter name #6116

Merged

Conversation

nitoqq
Copy link
Contributor

@nitoqq nitoqq commented Apr 30, 2020

To fix #6030

@wing328
Copy link
Member

wing328 commented May 1, 2020

Please run ./bin/javascript-petstore-all.sh to update the petstore samples so that the CI can verify the change.

@nitoqq
Copy link
Contributor Author

nitoqq commented May 7, 2020

It's done, please verify

@nitoqq nitoqq force-pushed the 6030-js-client-allow-dot-in-path-param branch from 1588b33 to e626ac3 Compare May 20, 2020 16:43
@jonathaningram
Copy link

Just a thought but should this be done in a more generic way? E.g. our API has paths based on the Google API Design resource names scheme which look like:

/v2/{name=accounts/*/domains/*}

The regexp change in this PR would not allow the above to work.

This might work? /\{([\w-\.=\*/]+)\}/g ?

@nitoqq nitoqq force-pushed the 6030-js-client-allow-dot-in-path-param branch from e626ac3 to 3f3961d Compare June 5, 2020 12:00
@wing328 wing328 added this to the 5.0.0 milestone Dec 4, 2020
@wing328
Copy link
Member

wing328 commented Dec 4, 2020

@wing328 wing328 merged commit 25c7ccf into OpenAPITools:master Dec 4, 2020
@wing328
Copy link
Member

wing328 commented Dec 4, 2020

@nitoqq thanks for the PR. Sorry for the delay in reviewing.

@jonathaningram valid point. Can you please submit another PR and we'll review accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Javascript client: allow dot in path parameters
4 participants