-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go] Fix issue #51, change object mapping from *interface{} to map[st… #60
Conversation
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors. Let me know if you need help fixing it. |
cc @bvwells as well |
@ilk I just noticed that your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors. Let me know if you need help fixing it. |
@ilk Can you also please run |
I've resolved the conflicts locally, updated the sample and triggered a CI job to test the updated Go Petstore. The result is good: https://circleci.com/gh/OpenAPITools/openapi-generator/617 (the failure is due to Scala client downloading dependencies, not related to Go client changes). If no one has any feedback/question, I'll merge it on coming Friday. |
@jimschubert thanks. I just merge it and will send another PR to update the Go petstore sample |
…kage based on effective Helidon version (OpenAPITools#60)
…-9.x chore(deps): update dependency ts-node to v9
This change made Map<String, Object> unmarshaling in Go impossible. :( |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
To fix #51 I propose the following changes:
Technical Commitee
@antihax
@wing328