C-Libcurl client: fix enum model generation #5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "..._parseFromJSON" template was buggy because the name of the _e type used was not the same than the generated. See the first argument of "..._convertToJSON" to see that the _e type used there was not the same
|
Hello @Angeall @zhemant |
6 tasks
|
Hello @michelealbano Could you please take a look at this PR because it may involve your PR #5477 ? |
|
Hi @Angeall Could you please execute ./bin/c-petstore.sh to regenerate the sample petstore and push them to this PR for reivew because it is required by RP checklist . |
I did, but it does not generate any change in git 😮 . |
|
Maybe your commit is not needed by the sample petstore. |
|
This PR unifies the enum name to {{projectName}}{{classVarName}}{{enumName}}_e after the PR #5477 It looks good to me. Please wait core team to merge. |
|
As I discussed in my PR, my code for enums did not cover model enums. This PR appears good to me. |
CI failure (fixed in the master) not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes commit fc9d458
The "..._parseFromJSON" template was buggy because the name of the _e type used was not the same than the generated.
See the first argument of "..._convertToJSON" to see that the _e type used there was not the same
About #5477 (#5091 and #4293)
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.