[cli][core] Add support for dry-run and display #5332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up some lint warnings and improve general code cleanliness of DefaultGenerator. Specifically: * logger strings are now using the built-in log formatter rather than constructing new strings regardless of log level. * Diamond operators are used where possible * Some long-unused commented code has been removed * Lambdas are used where possible * Redundant operations are merged (HashMap constructor used rather than subsequent putAll on a collection, for example)
CLI now supports `--dry-run`, which will output a file change status similar to git status --porcelain. The user may also specify `--verbose` for a one-liner below each file explaining why the change operation might take place.
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
* 👕🎨 Minor refactor DefaultGenerator This cleans up some lint warnings and improve general code cleanliness of DefaultGenerator. Specifically: * logger strings are now using the built-in log formatter rather than constructing new strings regardless of log level. * Diamond operators are used where possible * Some long-unused commented code has been removed * Lambdas are used where possible * Redundant operations are merged (HashMap constructor used rather than subsequent putAll on a collection, for example) * [cli][core] Add support for dry-run and display CLI now supports `--dry-run`, which will output a file change status similar to git status --porcelain. The user may also specify `--verbose` for a one-liner below each file explaining why the change operation might take place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI now supports
--dry-run, which will output a file change status similar to git status --porcelain. This option aligns with #1811 for providing users and template authors more details about targeted outputs. This--dry-runoption will be necessary in order to present users with vendor extensions which heavily rely on the generator inputs and often on logic defined by some generator implementations which is only evaluated during generation.The user may also specify
--verbosefor a one-liner below each file explaining why the change operation might take place.This PR also cleans up some lint warnings and improves general code cleanliness
of DefaultGenerator.
Specifically:
constructing new strings regardless of log level.
subsequent putAll on a collection, for example)
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.cc @OpenAPITools/generator-core-team