CircleCI comment spring-mvc-j8-localdatetime

[jmini]

No description provided.

[jmini]

My attempt change port did not work. I now have commented spring-mvc-j8-localdatetime

[jimschubert]

@jmini this title is still marked as a work in progress. Is this ready to merge?

[jmini]

Lets see how CI looks like, I just merged master into this branch...

[jmini]

@jimschubert, @wing328, @cbornet : what is your opinion, should we comment the spring-mvc-j8-localdatetime test case in order for the CircleCI job to OK?

[jimschubert]

I think it's fine. do we have insight into how CircleCI runs this stuff? Are servers shared, it would bumping to a higher port solve this issue?

Could we consider modifying these settings using sed and a random port assignment function?

[wing328]

should we comment the spring-mvc-j8-localdatetime test case in order for the CircleCI job to OK?

Please try.

In my end, I'll try upgrading the setting file to CircleCI 2.0 to see if that works out better.

Ref: https://circleci.com/blog/launching-today-circleci-2-0-reaches-general-availability/

[jmini]

The current state of this PR is spring-mvc-j8-localdatetime commented, as you can see the builds were all green.

---

I now have a similar problem locally:
I try to run mvn clean verify with a pom file looking like this:

<project xmlns:xsi="http:/www.w3.org/2001/XMLSchema-instance" xmlns="http:/maven.apache.org/POM/4.0.0"
         xsi:schemaLocation="http:/maven.apache.org/POM/4.0.0 http:/maven.apache.org/maven-v4_0_0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>tmp</groupId>
    <artifactId>tmp-build-root</artifactId>
    <packaging>pom</packaging>
    <version>1.0.0-SNAPSHOT</version>
    <modules>

<module>samples/server/petstore/spring-mvc/</module>
<module>samples/server/petstore/spring-mvc-j8-async/</module>
<module>samples/server/petstore/spring-mvc-j8-localdatetime/</module>

    </modules>
</project>

Results:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] spring-mvc-server .................................. SUCCESS [  6.765 s]
[INFO] spring-mvc-server-j8-async ......................... SUCCESS [  3.948 s]
[INFO] spring-mvc-j8-localdatetime ........................ FAILURE [  0.492 s]
[INFO] tmp-build-root ..................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11.317 s
[INFO] Finished at: 2018-05-23T08:19:21+02:00
[INFO] Final Memory: 45M/859M
[INFO] ------------------------------------------------------------------------
[INFO] Destroying Spring FrameworkServlet 'dispatcher'
[ERROR] Failed to execute goal org.eclipse.jetty:jetty-maven-plugin:9.2.15.v20160210:start (start-jetty) on project spring-mvc-j8-localdatetime: Failure: ShutdownMonitorThread already started -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :spring-mvc-j8-localdatetime

I get an other error when I run mvn verify => then already spring-mvc-server-j8-async is failing.

I really do not know spring well enough. This is why @cbornet can maybe help us.

---

An other idea could be to update jetty to the latest version.

---

I propose to comment the project, in order to have a green CI build.

[jmini]

ci/circleci — Your tests failed on CircleCI

Job 250 is failing:

[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::              FAILED DOWNLOADS            ::
[warn] 	:: ^ see resolution messages for details  ^ ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: joda-time#joda-time;2.2!joda-time.jar
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
sbt.ResolveException: download failed: joda-time#joda-time;2.2!joda-time.jar
	at sbt.IvyActions$.sbt$IvyActions$$resolve(IvyActions.scala:294)

[jimschubert]

@jmini does this still need to be merged?

[jmini]

No you are right. I will close this PR, it does no longer make sense.