Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gradle] Add recommendations to validate task #5181

Closed
wants to merge 1 commit into from

Conversation

jimschubert
Copy link
Member

Adds recommendation/validation to the validate task in the gradle plugin.
This fixes #335 although there's no addition to the maven plugin, because none of CLI/Gradle/Maven do custom recommendations or validation in the generate task.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert jimschubert added this to the 4.3.0 milestone Jan 31, 2020
@jimschubert
Copy link
Member Author

cc @OpenAPITools/generator-core-team

@jimschubert
Copy link
Member Author

Caches on CI appear to have gotten messed up with this PR. I've opened another to retry.

@jimschubert jimschubert deleted the validate-in-plugins branch January 31, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validate --recommend option to maven and gradle plugin options.
1 participant