Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Cleanup ThreadPool with atexit rather than __del__ #5094

Merged
merged 6 commits into from
Jan 29, 2020
Merged

[python] Cleanup ThreadPool with atexit rather than __del__ #5094

merged 6 commits into from
Jan 29, 2020

Commits on Jan 23, 2020

  1. [python] Cleanup ThreadPool with atexit rather than __del__ 

    This removes the `__del__` function from the generated Python client,
and replaces it with a `cleanup` function. When a ThreadPool is created,
the cleanup function is registered with the `atexit` module.

This fixes OpenAPITools#5093, where the API client could hang indefinitely at
garbage collection.
    @fabianvf
    fabianvf committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    b6140f3 View commit details
    Browse the repository at this point in the history

  2. Update petstore examples

    @fabianvf
    fabianvf committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    a2e3676 View commit details
    Browse the repository at this point in the history

  3. Test to ensure threadpool is cleaned up

    @fabianvf
    fabianvf committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    6880e3f View commit details
    Browse the repository at this point in the history

  4. Docs now encourage using the context manager

    @fabianvf
    fabianvf committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    d8c5c55 View commit details
    Browse the repository at this point in the history

  5. Regenerate docs

    @fabianvf
    fabianvf committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    70f8021 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. Update samples

    @fabianvf
    fabianvf committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    1d179e0 View commit details
    Browse the repository at this point in the history