-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved to Swagger 2 annotations as well as SpringDoc instead of Springfox #4779
Conversation
@N4zroth thanks for the PR. Please PM me via Slack to discuss this PR when you've time. |
@N4zroth its realy important issue i think. Can you fix the conflicts or do you need help with it? I would like to have restdocs in the next releases of openapi-generator. |
I think Springfox is still far more used than Springdoc. So using v3 annotations should be an option atm. |
Yes, you are right. But the thing is springfox latest release was in June 2018. They don't support OpenApi 3. Yes, best case would be an option to choose between both of them. |
Any tentative timelines when this PR will be merged? |
It will be awesome if this MR can be included in the 5.0.0 milestone. |
Springfox v3 has been released and it supports OASv3. So we should stick with Springfox as it's much more popular and upgrade it to v3. |
Can we please have the support of springdoc as well for OAS 3 ? springfox is not popular for OpenAPI3. Springfox lacks of maintenance. The last release was more than two years ago. All projects since this date who needed OpenAPI 3 support in spring applications moved to springdoc. We really need this enhancement, and thank you for the support of springdoc as well. |
Is there any hope? |
Is there any progress please? It has been open for so long... |
I am interested in this issue as well. If there is nobody else, I hope around Christmas time I could invest some time into fixing merge conflicts. |
Springfox is abandoned , 3.0 is their last release and yet another year passed, please use springdoc. |
FWIW - this may be a solution for those looking to use |
Changed the generated annotations to Swagger 2 annotations, built the samples and verified them by hand (and maven clean compile). The only thing I can't get to work is the @Schema in springboot-reactive as it results in class=List.class which is obviously incorrect. The other projects compile and seem to be correct. Would love to be corrected if need be, though :)
The underlying issue was #4245
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)