Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate hashCode, equals, toString #4648

Merged
merged 10 commits into from
Dec 4, 2019
Merged

Regenerate hashCode, equals, toString #4648

merged 10 commits into from
Dec 4, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 29, 2019

Regenerate hashCode, equals, toString in CodegenParameter, CodegenProperty, CodegenOperation, etc using Intellji IDE

cc @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 added this to the 4.2.2 milestone Nov 29, 2019
@wing328 wing328 added the WIP Work in Progress label Nov 29, 2019
@wing328 wing328 removed the WIP Work in Progress label Nov 30, 2019
@wing328 wing328 modified the milestones: 4.2.2, 4.2.3 Dec 2, 2019
@wing328 wing328 merged commit e774db0 into master Dec 4, 2019
@wing328 wing328 deleted the code_improve1 branch December 4, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant