[Slim] Refactoring #402
Merged
[Slim] Refactoring #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.lcok should be commited to SVN. Official recommendation https://getcomposer.org/doc/01-basic-usage.md#commit-your-composer-lock-file-to-version-control
ybelenko
force-pushed
the
slim_refactoring
branch
from
037fed4 to
0296c4c
Compare
|
@ackintosh Now I'm satisfied with the result. Please, review and merge when possible. |
wing328
reviewed
Jul 1, 2018
...openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpSlimServerCodegen.java
Outdated
Show resolved
Hide resolved
ackintosh
reviewed
Jul 1, 2018
ybelenko
force-pushed
the
slim_refactoring
branch
from
0296c4c to
f45bb64
Compare
ybelenko
force-pushed
the
slim_refactoring
branch
from
f45bb64 to
7b630f1
Compare
|
@ackintosh @wing328 Both recommendations has been applied |
|
The shippable failure has been fixed in the master. |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* [Slim] Cleanup samples. composer.lock excluded from .gitignore composer.lcok should be commited to SVN. Official recommendation https://getcomposer.org/doc/01-basic-usage.md#commit-your-composer-lock-file-to-version-control * [Slim] Refactor. Extend AbstractPhpCodegen class * [Slim] Adjust the names (script, sample folder, generator) to lang option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.1.x,4.0.x. Default:master.Description of the PR
I found beautiful
AbstractPhpCodegenclass. In this pull requestPhpSlimServerCodegengets new config options and extendsAbstractPhpCodegen. Now Slim codegen much smaller and cleanier.Also I noticed old LICENSE file in Slim samples. Current codegen doesn't create LICENSE file for Slim, so I've deleted it.
cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh