Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scala][client] ScalaAkkaClientCodegenTest: refactor assertions #3893

Merged
merged 1 commit into from
Sep 16, 2019
Merged

[scala][client] ScalaAkkaClientCodegenTest: refactor assertions #3893

merged 1 commit into from
Sep 16, 2019

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Sep 15, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@sullis sullis changed the title ScalaAkkaClientCodegenTest: refactor assertions [scala][client] ScalaAkkaClientCodegenTest: refactor assertions Sep 15, 2019
@sullis
Copy link
Contributor Author

sullis commented Sep 15, 2019

@wing328

@wing328
Copy link
Member

wing328 commented Sep 16, 2019

cc @clasnake (2017/07) @jimschubert (2017/09) @shijinkui (2018/01) @ramzimaalej (2018/03)

Copy link
Contributor

@ramzimaalej ramzimaalej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 3f9d1b1 into OpenAPITools:master Sep 16, 2019
@sullis sullis deleted the ScalaAkkaClientCodegenTest-refactor-assertions branch September 16, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants