Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-angular: Set Content-Type for multipart requests in angular #3779

Merged

Conversation

eirikandre
Copy link
Contributor

@eirikandre eirikandre commented Aug 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Have wrapped JSON.stringify({{paramName}}) like this: new Blob([JSON.stringify({{paramName}})], {type: 'application/json'})

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)

fixes #3776

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for the PR

@macjohnny macjohnny added this to the 4.1.2 milestone Aug 28, 2019
@macjohnny macjohnny changed the title Set Content-Type for multipart requests in angular. fix #3776 typescript-angular: Set Content-Type for multipart requests in angular Aug 28, 2019
@macjohnny macjohnny merged commit 2016bc0 into OpenAPITools:master Aug 28, 2019
@wing328
Copy link
Member

wing328 commented Sep 12, 2019

@eirikandre thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][TypeScript] Multipart request missing Content-Type for models
3 participants