Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java-client][java-jaxrs-server][jackson] Add @JsonPropertyOrder to models #3778

Merged
merged 5 commits into from
Aug 29, 2019

Conversation

jmini
Copy link
Member

@jmini jmini commented Aug 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (xor instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. Java @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

Description of the PR

Fixes #3629

As discussed with the @OpenAPITools/generator-core-team, we do not add a new flag for this.

@auto-labeler
Copy link

auto-labeler bot commented Aug 28, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jmini
Copy link
Member Author

jmini commented Aug 29, 2019

@cbornet I did the requested change.

@cbornet
Copy link
Member

cbornet commented Aug 29, 2019

👍

@jmini jmini merged commit 87727de into OpenAPITools:master Aug 29, 2019
@jmini jmini added this to the 4.1.2 milestone Aug 29, 2019
@vmariusv
Copy link

Can this be added to Java Spring generator too ?

@aitia
Copy link

aitia commented Jun 28, 2023

Can this be added to Java Spring generator too please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][java][jackson] add @JsonPropertyOrder annotation
4 participants