Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-rxjs] support HEAD method, improve formatting #3766

Merged

Conversation

denyo
Copy link
Contributor

@denyo denyo commented Aug 27, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add support for HEAD method. Improve formatting regarding whitespace and missing semi colons.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)

denyo added 4 commits August 27, 2019 09:44
# Conflicts:
#	samples/client/petstore/typescript-rxjs/builds/default/.openapi-generator/VERSION
#	samples/client/petstore/typescript-rxjs/builds/with-interfaces/.openapi-generator/VERSION
@denyo denyo changed the title Feature/rxjs method head and formatting [typescript-rxjs] support HEAD method, improve formatting Aug 27, 2019
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny added this to the 4.1.2 milestone Aug 27, 2019
@macjohnny macjohnny merged commit 5bd6307 into OpenAPITools:master Aug 27, 2019
@denyo denyo deleted the feature/rxjs-method-head-and-formatting branch August 27, 2019 09:27
@wing328
Copy link
Member

wing328 commented Sep 12, 2019

@denyo thanks for the PR, which has been included in the v4.1.2 release: https://twitter.com/oas_generator/status/1172068944355528705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants