Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Qt5 client sample test #3415

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Run Qt5 client sample test #3415

merged 1 commit into from
Aug 8, 2019

Conversation

MartinDelille
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

I just added Qt5 PetStore sample test. I'm not sure Qt5 is installed on the CI so I'll fix it if not.

@ravinikam @stkrwork @etherealjoy

@MartinDelille MartinDelille force-pushed the run-qt5-client-test branch 2 times, most recently from e698e65 to 036430f Compare July 24, 2019 09:35
@MartinDelille
Copy link
Contributor Author

Unfortunately, since I upgrade the qt5 client petstore example to openapi 3.0 spec, the test fails to compile: https://travis-ci.org/OpenAPITools/openapi-generator/builds/562992191#L5084

Should we revert #3400 ?

@etherealjoy
Copy link
Contributor

etherealjoy commented Jul 25, 2019 •
edited
Loading

Yes, Lets revert #3400 . I did not have a chance to compile it, and assumed it was done.
You can create the bug for the non compiling, It seems to be some mustache error.

This was referenced Jul 25, 2019
Closed
Merged
@MartinDelille
Copy link
Contributor Author

Done here: #3458

@MartinDelille
Copy link
Contributor Author

CircleCI job failed: do I need to install Qt for CircleCI too? It doesn't seems that the issue is related.

@etherealjoy
Copy link
Contributor

I restarted the CI job and it passed.

@wing328
Copy link
Member

wing328 commented Jul 30, 2019

Another option is to use drone.io that we just setup over the weekend: https://github.com/OpenAPITools/openapi-generator/blob/master/CI/.drone.yml

If there's a docker image with those dependencies installed, we can set it up very easily with drone.io.

@etherealjoy
Copy link
Contributor

@wing328
do you have more comments, looks fine for me.

@wing328
Copy link
Member

wing328 commented Aug 8, 2019

No more feedback/question from me. The change looks good 👍

@wing328 wing328 merged commit 1152af4 into OpenAPITools:master Aug 8, 2019
@wing328 wing328 added this to the 4.1.0 milestone Aug 9, 2019
jimschubert added a commit that referenced this pull request Aug 11, 2019
@jimschubert
Merge branch 'master' into server-variable-substitution
96e803c 
* master: (122 commits)
  Fix #3604 by adding undefined as return type to headers and credentials methods in runtime.ts (#3605)
  Prepare 4.1.1-SNAPSHOT (#3603)
  Prepare 4.1.0 release (#3597)
  [java][client][jax-rs] Add a constant for Jackson @JsonProperty (#3560)
  restore openapi3 petstore.yaml (#3590)
  Add a new NodeJS Express server generator (#3567)
  [C#][client][csharp-netcore] Fix csharp netcore defaultheaders (#3562)
  Fix issue deserializing to nullptr (#3572)
  [OCaml] Add file post-processing (#3583)
  [dart2] Fix up test code generation, double deserialization, 'new' keyword deprecation (#3576)
  Run Qt5 client sample test (#3415)
  typescript-fetch: allow configuration of headers and credentials (#3586)
  using partials in ruby api_client (#3564)
  [OCaml] Added optional params support in API operations (#3568)
  [Rust Server] Generate valid Rustdocs for lazy_static items (#3556)
  Fix NPM build for Typescript-fetch (#3403)
  Expand path templates via resttemplate's uriTemplateHandler (#3500)
  Readme updated with a new tutorial and company using OpenAPI Generator (#3566)
  Fix logic of `getNullableType` of csharp server and client. (#3537)
  [Ruby] clean up Ruby dev dependencies (#3551)
  ...
@MartinDelille MartinDelille deleted the run-qt5-client-test branch August 11, 2019 09:54
@wing328
Copy link
Member

wing328 commented Aug 12, 2019 •
edited
Loading

We start seeing the following intermittent build errors in the master branch:

********* Start testing of UserApiTests *********
Config: Using QtTest library 5.10.1, Qt 5.10.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.8.4)
PASS   : UserApiTests::initTestCase()
QDEBUG : UserApiTests::createUserTest() got a request body
PASS   : UserApiTests::createUserTest()
QDEBUG : UserApiTests::createUsersWithArrayInputTest() got a request body
PASS   : UserApiTests::createUsersWithArrayInputTest()
QDEBUG : UserApiTests::createUsersWithListInputTest() got a request body
PASS   : UserApiTests::createUsersWithListInputTest()
PASS   : UserApiTests::deleteUserTest()
QDEBUG : UserApiTests::getUserByNameTest() "johndoe"
PASS   : UserApiTests::getUserByNameTest()
QDEBUG : UserApiTests::loginUserTest() "logged in user session:1565589377293"
PASS   : UserApiTests::loginUserTest()
PASS   : UserApiTests::logoutUserTest()
QDEBUG : UserApiTests::updateUserTest() got a request body
PASS   : UserApiTests::updateUserTest()
PASS   : UserApiTests::cleanupTestCase()
Totals: 10 passed, 0 failed, 0 skipped, 0 blacklisted, 67ms
********* Finished testing of UserApiTests *********
./build-and-test.bash: line 12: 27637 Segmentation fault      (core dumped) ./PetStore
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (pet-test) on project CppQt5PetstoreClientTests: Command execution failed. Process exited with an error: 139 (Exit value: 139) -> [Help 1]

Please take a look when you've time. We will restart the job for the time being.

@MartinDelille
Copy link
Contributor Author

This might be due to memory leak fixed here: #3661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etherealjoy etherealjoy etherealjoy approved these changes

Assignees
No one assigned
Labels
Client: C++ Enhancement: CI/Test
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinDelille @etherealjoy @wing328