Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated code in cases where multiple APIs define the same options. #3206

Closed
wants to merge 1 commit into from

Conversation

brendandburns
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add the class name to the options struct in case APIs cough Kubernetes cough re-use the same options names in multiple different revisions of the API.

cc @antihax @bvwells @grokify @kemokemo

@wing328
Copy link
Member

wing328 commented Jun 24, 2019

Looks like the CI tests failed with the following errors:

# _/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/go/go-petstore
go-petstore/api_fake.go:109:92: undefined: FakeOuterBooleanSerializeOpts
go-petstore/api_fake.go:207:94: undefined: FakeOuterCompositeSerializeOpts
go-petstore/api_fake.go:309:91: undefined: FakeOuterNumberSerializeOpts
go-petstore/api_fake.go:407:91: undefined: FakeOuterStringSerializeOpts
go-petstore/api_fake.go:752:167: undefined: TestEndpointParametersOpts
go-petstore/api_fake.go:896:85: undefined: TestEnumParametersOpts
go-petstore/api_fake.go:999:166: undefined: TestGroupParametersOpts
go-petstore/api_pet.go:109:88: undefined: DeletePetOpts
go-petstore/api_pet.go:530:96: undefined: UpdatePetWithFormOpts
go-petstore/api_pet.go:612:89: undefined: UploadFileOpts
go-petstore/api_pet.go:612:89: too many errors
FAIL	_/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/go [build failed]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (go-test) on project Goswagger: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]

@wing328
Copy link
Member

wing328 commented Jun 24, 2019

May I suggest adding an option in the Go client generator to make the change backward compatible?

@wing328
Copy link
Member

wing328 commented Nov 21, 2019

@brendandburns I've filed #4564 to add an option to prefix the struct with the class name so closing this one.

@wing328 wing328 closed this Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants