[BUG][cpp-qt5-client] Header params in api-body operations use param name instead of value #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Closed
6 tasks
etherealjoy
approved these changes
Apr 24, 2019
jimschubert
added a commit
that referenced
this pull request
Apr 25, 2019
* master: (40 commits)
Remove quotation marks around {{paramName}} for header params in api-body.mustache (#2727)
Add FiNC Technologies (#2728)
fix missing parenthesis for http bearer auth (#2723)
Add missing closing parenthesis (#2720)
update perl test with correct body parameter (#2717)
[Java][Spring] Fix template for reactive implementation with `interfaceOnly` parameter (#2437)
Bugfix(Perl): Support nested primitive types in ARRARY or HASH for basic object (#2713)
Remove `-XX:MaxPermSize` (#2712)
Remove setting generateAliasAsModel in rust server generator (#2714)
update rust server samples
Revert "update rust samples"
update rust samples
update samples
[Rust Server] Improve XML support (#2504)
Improve CONTRIBUTING.md (#2699)
[PHP][Lumen] Rename template folder (#2707)
[aspnetcore] Support async tasks and some code cleanups (#2629)
[C++][Pistache] Fixed #2643 (#2653)
update petstore samples (#2697)
[JAVA][Webclient]fix select body for url encoded media type. (#2686)
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Header parameters are broken in the
cpp-qt5-clientdue to quotation of the{{paramName}}value -- the name of the parameter is used instead of the value. Remove quotation marks.Fixes issue 2726.