Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate initialCaps and replace with camelize #2546

Merged
merged 2 commits into from
Apr 1, 2019
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Mar 29, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

cc @OpenAPITools/generator-core-team

@wing328 wing328 added the WIP Work in Progress label Mar 29, 2019
@jimschubert
Copy link
Member

Can I propose that we separate TitleCase and camelCase from camelize into two separate methods? I assume initialCaps existed because many don't realize that camelize(value) is title cased and camelize(value, boolean=false) is camelCase.

@wing328
Copy link
Member Author

wing328 commented Mar 31, 2019

I assume initialCaps existed because many don't realize that camelize(value) is title cased and

Based on what I recall, initialCaps was already in the code base before I added camelize and underscore a while go. The implementations of initialCaps does not fully meet our requirement as it only make the first letter upper case and that's why we want to replace it with camelize

Can I propose that we separate TitleCase and camelCase from camelize into two separate methods?

Good idea. What about introducing the following methods and mark camelize, underscore as private?

  • toSnakeCase
  • toTitleCase
  • toCamelCase
  • toKebabCase

@jimschubert
Copy link
Member

@wing328 I think the four methods you've listed would be very clear, and easily discoverable by a good IDE.

I remember looking for titleCase and kebabCase when I first started contributing, a few years ago and didn't see these options. After a short while, I realized the usage of the current methods… but I think the above would be easier for new contributors.

👍

@wing328
Copy link
Member Author

wing328 commented Apr 1, 2019

@jimschubert 👌 I'll do that in a separate PR.

@wing328 wing328 merged commit 69ad9a9 into master Apr 1, 2019
@wing328 wing328 deleted the remove_initialCaps branch April 1, 2019 03:21
jimschubert added a commit that referenced this pull request Apr 2, 2019
* master: (133 commits)
  #2503: fix out-of-memory issue with nested objects with arrays with maxItems set by limiting to max. 5 example items (#2536)
  remove emitDefaultValue option (#2559)
  fix EmitDefaultValue default vallue with false (#2558)
  Added API Key auth to rust-server (#2459)
  remove initialCaps and replace with camelize (#2546)
  Add packageName configuration to maven (#2429)
  [Typescript AngularJS] fix Extra package prefix in api parameters operations (#2522)
  #1023 - [Scala] Use status family during response processing (#1024)
  Generate setters for readonly properties in server code (#1582)
  [JS] fix NPE for null string and improve Travis config file (#2553)
  [elm] Update ISO 8601 library (fixes missing time zone designator) (#2545)
  [csharp] update sample after #2528 (#2550)
  [JavaScript] fix index.js, ApiClient.js and test files generated to incorrect location (#2511)
  Aspnetcore nullable support (#2529)
  Csharp nullable support (#2528)
  [C++] [Qt5] Add enum support for client and server (#2339)
  Fixed typo in migration-from-swagger-codegen.md (#2548)
  [TypeScript Client] fix install Aurelia + fix use deprecated function (#2514)
  [KOTLIN] fix var name not correctly sanitized (#2537)
  Update swagger-parser to '2.0.11-OpenAPITools.org-1' (#2262)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants