Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kotlin default value #2513

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Fix Kotlin default value #2513

merged 2 commits into from
Mar 27, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Mar 26, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix Kotlin default value "null" with null

cc @jimschubert (2017/09), @dr4ke616 (2018/08)

@markus-wa
Copy link
Contributor

Thanks for the quick fix!

Looks good on my end, though I see that Travis isn't quite happy yet: https://travis-ci.org/OpenAPITools/openapi-generator/builds/511422253#L1009 - those tests probably need some adjustments.

Much better approach than in #2487, I didn't know we could override that function here 🙂

@wing328
Copy link
Member Author

wing328 commented Mar 27, 2019

CircleCI failure has been addressed in the master.

@wing328 wing328 merged commit 1c1c1ef into master Mar 27, 2019
@wing328 wing328 deleted the kotlin_default_value branch March 27, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants