Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java Vertx client dependency #2507

Merged
merged 3 commits into from
Mar 26, 2019
Merged

Update Java Vertx client dependency #2507

merged 3 commits into from
Mar 26, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Mar 26, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Update Java Vertx lib dependency
  • Update Java vertx samples using java8 for dateLibrary
  • Update Java client option (not to hard code the version but use things like 2.8.x instead)

@wing328
Copy link
Member Author

wing328 commented Mar 26, 2019

The shippable CI error is due to failure in downloading Elm dependencies

@wing328 wing328 merged commit 5a6f4cb into master Mar 26, 2019
@wing328 wing328 deleted the update_java_dep branch March 26, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant