[elm] Import types in operations #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And stringify UUIDs. Fixes OpenAPITools#2484.
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
Wow, awesome! 😊 I can try out, if it works for our project, as soon as the fix is available with |
andys8
approved these changes
Mar 23, 2019
| hasUuid = hasUuid | ||
| || op.queryParams.stream().filter(param -> param.isUuid).findAny().isPresent() | ||
| || op.pathParams.stream().filter(param -> param.isUuid).findAny().isPresent() | ||
| || op.headerParams.stream().filter(param -> param.isUuid).findAny().isPresent(); |
There was a problem hiding this comment.
Not sure about the types, but you can probably combine all params (query, path, header) into a single collection or stream first, and filter afterwards only once to reduce duplication?
There was a problem hiding this comment.
You're absolutely right this isn't very clean. I've updated the PR.
|
Could be merged :) @wing328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And stringify UUIDs. Fixes #2484.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
cc @wing328