Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type declaration to typescript-fetch runtime #2466

Merged
merged 2 commits into from
Mar 22, 2019

Conversation

janbuchar
Copy link
Contributor

closes #2461

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Teyras could you please re-generate the samples?

@janbuchar
Copy link
Contributor Author

@macjohnny done

@macjohnny
Copy link
Member

the CI failures are due to outdated ruby examples, nothing related to this PR.

@wing328 wing328 added this to the 4.0.0 milestone Mar 22, 2019
@wing328 wing328 merged commit db1b637 into OpenAPITools:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][typescript-fetch] implicit any in runtime.ts
3 participants