Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAVEN PLUGIN] fix javadoc, fix sonarlint issues in module openapi-generator-cli #2399

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

karismann
Copy link
Contributor

@karismann karismann commented Mar 14, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.

Description of the PR

fix mvn verify -f modules/openapi-generator-cli/pom.xml who failed locally (with jdk1.8.0_171) cause of javadoc warning with maven-javadoc-plugin 3.0.1 but not with 3.1.0 anymore (actually no error in circleci but probably cause of #705)
fix warning line 2 column 2 - Error: <additionalproperties> is not recognized! in circle-ci log in openapi-generator-maven-plugin module
fix some sonarlint issues in module openapi-generator-cli

@wing328 wing328 added this to the 4.0.0 milestone Mar 20, 2019
@wing328 wing328 merged commit 218c2e7 into OpenAPITools:master Mar 20, 2019
@wing328 wing328 changed the title [MAVEN PLUGIN] fix javadoc + sonarlint [MAVEN PLUGIN] fix javadoc, sonarlint issues in module openapi-generator-cli Mar 20, 2019
@wing328 wing328 changed the title [MAVEN PLUGIN] fix javadoc, sonarlint issues in module openapi-generator-cli [MAVEN PLUGIN] fix javadoc, fix sonarlint issues in module openapi-generator-cli Mar 20, 2019
@karismann karismann deleted the fix-maven-javadoc-plugin branch March 20, 2019 08:48
@jimschubert jimschubert mentioned this pull request Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants