-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for ability to easily debug newly created codegen classes. #2388
Conversation
OK. I think I'm doing something wrong where I need to update the target samples with the new code so that the uncommitted changes thing doesn't flag. Originally, I thought I wasn't supposed to commit the generated sample code. I'll take another stab at this soon. |
@jimschubert @ackintosh
|
bb8472c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jason-henriksen thank you for this contribution, which will help to improve the workflow for the community! |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
,./bin/security/{LANG}-petstore.sh
and./bin/openapi3/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,. Default:3.4.x
,4.0.x
master
.Description of the PR
Adds a unit test to the meta command generated code. Running that unit test under the debugger causes the cli code to be run under the debugger which makes the debug experience of working on a new codegen library much easier to work with and enhance.