Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for ability to easily debug newly created codegen classes. #2388

Merged
merged 4 commits into from
Mar 16, 2019

Conversation

jason-henriksen
Copy link
Contributor

PR checklist

  • [ X ] Read the contribution guidelines.
  • [ X ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ X ] Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • [ N/A ] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Adds a unit test to the meta command generated code. Running that unit test under the debugger causes the cli code to be run under the debugger which makes the debug experience of working on a new codegen library much easier to work with and enhance.

@jason-henriksen
Copy link
Contributor Author

OK. I think I'm doing something wrong where I need to update the target samples with the new code so that the uncommitted changes thing doesn't flag. Originally, I thought I wasn't supposed to commit the generated sample code. I'll take another stab at this soon.

@jason-henriksen
Copy link
Contributor Author

This PR addresses the issue: #2222

It is also a fixed attempt at the work in this PR: #2221
( 2221 is the same thing, so it could be closed. )

@jason-henriksen
Copy link
Contributor Author

@jimschubert @ackintosh
For your review. Thank you for taking a look at it.

  • Jason

@ackintosh ackintosh added this to the 4.0.0 milestone Mar 16, 2019
@ackintosh
Copy link
Contributor

bb8472c
Yes, it was the reason why CI failed. 👍

Copy link
Contributor

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ackintosh ackintosh merged commit e5a0d18 into OpenAPITools:master Mar 16, 2019
@jimschubert
Copy link
Member

@jason-henriksen thank you for this contribution, which will help to improve the workflow for the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants