Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing various issues reported by Sonar (part 2) #2295

Merged
merged 3 commits into from
Mar 20, 2019
Merged

Fixing various issues reported by Sonar (part 2) #2295

merged 3 commits into from
Mar 20, 2019

Conversation

ramzimaalej
Copy link
Contributor

@ramzimaalej ramzimaalej changed the title Second part of fixing Sonar issues second part of fixing Sonar issues Mar 5, 2019
@wing328
Copy link
Member

wing328 commented Mar 10, 2019

cc @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Mar 10, 2019

For #788

@wing328 wing328 added this to the 4.0.0 milestone Mar 10, 2019
@jimschubert
Copy link
Member

Looks good to me. Any @OpenAPITools/generator-core-team have additional comments before merge?

@wing328
Copy link
Member

wing328 commented Mar 20, 2019

I'd another review and the changes look good to me.

@wing328 wing328 merged commit 3100afc into OpenAPITools:master Mar 20, 2019
@wing328 wing328 changed the title second part of fixing Sonar issues Fixing various issues reported by Sonar (part 2) Mar 20, 2019
@wing328
Copy link
Member

wing328 commented Mar 20, 2019

For #788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimschubert jimschubert jimschubert approved these changes

Assignees
No one assigned
Labels
Feature: Generator Issue: Bug
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ramzimaalej @wing328 @jimschubert