[R] Fix query parameters in the API client #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
changed the title
6 tasks
wing328
added a commit
that referenced
this pull request
Feb 23, 2019
* [R] fix namespace, use 2-space indentation (#2105) * fix namespace, indentation * use 2-space indentation in model files * update gitignore * use PascalCase for function naming (#2106) * [R] improve .travis.yml, .Rbuildignore (#2109) * update travis * enhance travis.yml * update travis, .Rbuildignore * [R] Add auto-generated documentations, change parameter naming (#2114) * add auto-generated doc for r client * remove module name * replace nil with void * [R] fix object serialization to JSON (#2129) * fix object serialization * fix array property seriziation * fix deserializing array of string * fix array of object deserialization * [R] Fix return type (#2140) * fix return type * update r petstore sample * add auto-generated tests (#2141) * rename file to conform to style guide (#2142) * add authenticaiton support to R (#2153) [R] Add authentication support, minor ApiClient refactor * rename test files * [R] various improvements and bug fixes (#2162) * fix api keys in headers * use optional parameter in function signature * fix property naming * fix doc assignment operator * [R] fix base64 encode (#2171) * fix base64 encode * fix basic http auth * fix typo, update instruction (#2203) * rename test files to conform to style guide (#2206) * [R] improve class constructor (#2208) * update constructor with optional parameter, default value * update r petstore sample * clean up files * regenerate files * Revert "rename test files to conform to style guide (#2206)" This reverts commit 90a6302. * fix query parameter in api client (#2214)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
To fix #2212