C# refactor improvements: .NET Standard and .NET Core #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes .NET 3.x, .NET 4.0, UWP, and the "5.0" option (which referred to PCL 5.0). This gives us a smaller footprint for maintenance, and doesn't necessarily block consumers from creating custom templates to support those target frameworks. A workaround for users wanting these options is to build against openapi-generator 3.3.4. This moves logic for applying additional properties to strategies per target framework, as a means to reduce maintenance overhead at the cost of maybe a little redundancy between strategies.
Wrap xunit console environment variables in quotes, to prevent yaml syntax error.
Try to use dos-style switches, attempting to remove yaml parse error in appveyor. Previous command matched appveyor docs, but resulted in the parser error.
Wrap full commands for netstandard tests in quotes
4 tasks
* master: (40 commits) [Python] remove default value from being fallback to example (#2213) Add petstore integration tests to Ruby OAS3 client (#2211) Gradle - make GenerateTask properties optional (#2185) skip bats installation (#2198) Something in the dependencies changed. This switch is no longer needed. (#1850) Use oauth token for basic bearer auth in Rust. (#2161) Fix missing nullable (#2189) Enable error handling in Java WebClient library, fixes #1243 (#1244) [core] fix referenced enum case (#2175) rest-template: allow array parameters in path using collectionFormat (#2177) update go petstore samples Fix string types for cpprestsdk client generator (#1676) update kotline samples Remove API Key Authentication code for go when cookie is used. (#1601) changed the package install instructions to install the .tgz package … (#1989) okhttp-gson: allow array parameters in path using collectionFormat (#2137) [Ruby] Fix regualr expression in error message (#2069) (#2139) [kotlin][client] bytearray conversion (#2166) [rust-server] Added client documentation to rust-server (#2159) [Java] Getter/Setter naming convention not followed in generated models (#2095) ...
|
@wing328 I think this is good for review if you want to check it out. |
|
@jimschubert 👍 will try it and let you know if I've any feedback. |
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Related to some discussion in #2014, this updates
csharp-refactorto handle only .NET Standard and .NET Core. Doing this simplifies much of the logic differences between .NET Framework and PCL options available in thecsharpgenerator, when compared to the .NET Standard and .NET Core options in thecsharp-refactorgenerator.As a result, this does change generator options and features by removing those which are not support in .NET Standard or .NET Core (e.g. no Fody property weaving).
The RestSharp dependency has a hard limit on
netstandard2.0. This works for both .NET Standard and .NET Core 2.0, and while it's possible that the library will work in one of the .NET Standard 1.x configurations, we will log a message explaining that the only supported configuration for the built-in template is .NET Standard 2.0. The .NET Standard 1.x framework options exist to enable developers to extend the generator with their own custom templates.