Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler error in angular typescript codegen #2149

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Fix compiler error in angular typescript codegen #2149

merged 2 commits into from
Feb 14, 2019

Conversation

macjohnny
Copy link
Member

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

fixes #2147

@macjohnny
Copy link
Member Author

cc @rolandbaettig

@macjohnny
Copy link
Member Author

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)

@macjohnny macjohnny closed this Feb 13, 2019
@macjohnny macjohnny reopened this Feb 13, 2019
Copy link

@rolandbaettig rolandbaettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixed the issue

@macjohnny
Copy link
Member Author

@wing328 could you please merge this one? it does not change any functionality but simply prevents a compilation error by disabling type checking in the particular part in the code.

@wing328 wing328 merged commit e01a786 into OpenAPITools:master Feb 14, 2019
@wing328 wing328 added this to the 4.0.0 milestone Feb 14, 2019
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@wing328 wing328 changed the title #2147: fix compiler error in angular typescript codegen Fix compiler error in angular typescript codegen Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][ANGULAR] Typescript compiler error when using formData
3 participants