Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASPNETCORE] Add support for central package version management #20401

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jan 5, 2025

based on #20192

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title Urganot central package version management option [ASPNETCORE] Add support for central package version management Jan 5, 2025
@Urganot
Copy link

Urganot commented Jan 6, 2025

I fixed it and opened up a new pr #20403 #20403

Urganot and others added 2 commits January 6, 2025 22:03
#20403)

* Fixed default value for usePackageVersions

* Regenerated docs
@wing328
Copy link
Member Author

wing328 commented Jan 6, 2025

@wing328
Copy link
Member Author

wing328 commented Jan 6, 2025

FYI. Tested with optout and the output built locally without errors.

@Urganot
Copy link

Urganot commented Jan 6, 2025

I know what happens here.
Because there is no version in the csproj file, it tries to use the lowest possible. this obviously doesnt work.
In this case this is the correct behaviour though. when using centralized version management, you need to have a Directory.Packages.props file in your solution folder. in there you set the version of your packages. Without this file, it will fail. The problem is that generating this file into the generated project would defeat the purpose of this change because I want to control my versions from my non generated solution.
When using optout, it will put in the package versions. that is why it work in that case
I am not sure how this should be handled.

@wing328
Copy link
Member Author

wing328 commented Jan 7, 2025

Without this file, it will fail. The problem is that generating this file into the generated project would defeat the purpose of this change because I want to control my versions from my non generated solution.

how do you use it in your non-generated solution?

maybe creating a simple HelloWorld C# project/app that depends on or consumes samples/server/petstore/aspnetcore-8.0-use-centralized-package-version-management ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants