update sample tests, fix Java tests #20300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./bin/generate-samples.sh
does not update generated test files, because "Test files never overwrite an existing file of the same name." Therefore many test files in the samples directory were outdated. I temporarily changed the OpenAPI Generator code to allow overwriting test files and then ran./bin/generate-samples.sh
.(@wing328 As a permanent solution for this problem, we could introduce a new setting which allows test files to be overwritten. If you think this is a good idea, please let me know. I would then create a PR for this.)
For some languages I wasn't sure what needs to be reverted. In case of doubt I reverted all overwritten files of the language or of a given sample project. For Java only, I added the reverted files to test_file_list.yaml.
samples/client/petstore/java/okhttp-gson-dynamicOperations
to the CircleCI pipeline, because it contained many custom tests, but wasn't run in any pipeline.forkMode
setting in Java generators. (more info on StackOverflow)junit-platform-runner
in cases where it is not necessary anymore. If thejunit-platform-runner
dependency was present and we were usingmaven-surefire-plugin
version 3, no tests were being run.I have split the changes into several commits to make them as comprehensible as possible. It might be helpful to review the commits one by one.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)