[Kotlin] fix #20231, OkHttp client can handle a field with a list of files #20274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is basically the same one as created a few days ago (#20232) but it removes the following line inside one of the new
addPartToMultiPart
methods:This way, the behavior when adding null values is still the same.
issue: Kotlin OkHttp client does not process correctly when a field in the endpoint is defined as an array of lists like this:
If the autogenerated client is used, the server will receive always 1 item in the list but it is not a file or anything and it is trying to serialize like a normal object.
I noticed this issue while developing my own project, so I modified this code (by looking at the Java counterpart that can be seen here) and tested it by building the project in my local machine and adding the plugin to my project manually.
I tried to add some testing (I added the faulty specification) but I was not really sure how to do it. Also by reading the documentation, it didn't find it very clearly what I should do. Any guidance regarding how to add test for that would be very much appreciated.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@wing328 I created the tests and I will add them in a separate PR so it doesn't becomes too big.