-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin Server] Update Ktor to the next major version 3 #20245
Conversation
@Stexxe thanks for the PR can you please review the build failure when you've time? |
@wing328, all the issues are fixed now. |
@Stexxe all tests passed. If no further feedback from anyone, I'll merge it over the weekend. cc @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10) |
lgtm! |
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java
Outdated
Show resolved
Hide resolved
I tested with
but didn't see any difference in the output (compared with not setting enableKotlinSerialization and setting enableKotlinSerialization to true) how can I test the option? |
Can you please help me figure out why the |
I'll take a look tomorrow and push a fix if possible. Thanks again for filing the PR to start with |
I've removed this property altogether. Please take a look. |
modules/openapi-generator/src/main/resources/kotlin-server/libraries/ktor/api.mustache
Show resolved
Hide resolved
.../server/petstore/kotlin-server-modelMutable/src/main/kotlin/org/openapitools/server/Paths.kt
Outdated
Show resolved
Hide resolved
FYI. I added Will merge this PR tomorrow or this weekend so that users will get ktor (3.x) by default. |
FYI. Merged #20327 with some minor fixes to ensure ktor2 produces the same output as before. |
technical committee: @stefankoppier
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)