Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin Server] Update Ktor to the next major version 3 #20245

Merged
merged 9 commits into from
Dec 14, 2024

Conversation

Stexxe
Copy link
Contributor

@Stexxe Stexxe commented Dec 4, 2024

  • Update the Ktor version in the Kotlin Server template to 3.0.2.
  • Fix compilation errors of the generated code.

technical committee: @stefankoppier

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Dec 5, 2024

@Stexxe thanks for the PR

can you please review the build failure when you've time?

@Stexxe
Copy link
Contributor Author

Stexxe commented Dec 6, 2024

@wing328, all the issues are fixed now.

@wing328
Copy link
Member

wing328 commented Dec 6, 2024

@Stexxe all tests passed.

If no further feedback from anyone, I'll merge it over the weekend.

cc @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10)

@e5l
Copy link
Contributor

e5l commented Dec 6, 2024

lgtm!

@Stexxe Stexxe requested a review from wing328 December 9, 2024 07:59
@wing328
Copy link
Member

wing328 commented Dec 9, 2024

I tested with

 java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g kotlin-server -i modules/openapi-generator/src/test/resources/3_0/petstore.yaml -o /tmp/kotlin-server23 --additional-properties enableKotlinSerialization=false

but didn't see any difference in the output (compared with not setting enableKotlinSerialization and setting enableKotlinSerialization to true)

how can I test the option?

@Stexxe
Copy link
Contributor Author

Stexxe commented Dec 10, 2024

I tested with

 java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g kotlin-server -i modules/openapi-generator/src/test/resources/3_0/petstore.yaml -o /tmp/kotlin-server23 --additional-properties enableKotlinSerialization=false

but didn't see any difference in the output (compared with not setting enableKotlinSerialization and setting enableKotlinSerialization to true)

how can I test the option?

Can you please help me figure out why the additionalProperties.containsKey(Constants.KOTLIN_SERIALIZATION) call returns false when the enableKotlinSerialization passed as an additional property?

@wing328
Copy link
Member

wing328 commented Dec 10, 2024

I'll take a look tomorrow and push a fix if possible.

Thanks again for filing the PR to start with

@Stexxe
Copy link
Contributor Author

Stexxe commented Dec 10, 2024

I've removed this property altogether. Please take a look.

@Stexxe Stexxe requested a review from wing328 December 12, 2024 10:09
@wing328
Copy link
Member

wing328 commented Dec 12, 2024

FYI. I added ktor2 via 24ddb33 (should have filed a PR)

Will merge this PR tomorrow or this weekend so that users will get ktor (3.x) by default.

@wing328 wing328 merged commit f766f44 into OpenAPITools:master Dec 14, 2024
45 checks passed
@wing328
Copy link
Member

wing328 commented Dec 14, 2024

FYI. Merged #20327 with some minor fixes to ensure ktor2 produces the same output as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants