Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate micronaut openapi generator #20107

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented Nov 15, 2024

No description provided.

@altro3 altro3 force-pushed the micronaut branch 2 times, most recently from 53b34d9 to e4f504c Compare November 15, 2024 09:14
@altro3 altro3 changed the title Add deprecated message for micronaut generator and links to actual micronaut generator Deprecate micronaut openapi generator Nov 15, 2024
@altro3
Copy link
Contributor Author

altro3 commented Nov 15, 2024

@wing328 look to this, please

Copy link

@scprek scprek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the website also be updated to put a deprecated notes on the generators list page and on the details page (unless that is derived from the Java docs?).

@altro3
Copy link
Contributor Author

altro3 commented Nov 15, 2024

@scprek done

@scprek
Copy link

scprek commented Nov 15, 2024

Excellent. This will help a lot!

@wing328
Copy link
Member

wing328 commented Nov 16, 2024

Have you talked to @andriy-dmytruk (creator of the generator) about this change?

I understood there are "official" implementation but there may be users out there preferring to use this one instead.

@altro3
Copy link
Contributor Author

altro3 commented Nov 16, 2024

@wing328 It was he who moved it to micronaut. Because he works at Oracle, and micronaut is now an Oracle product.

It's the same generator, it's just that this openapi generator is now updated very rarely and we couldn't wait so long for releases to fix bugs. So we decided to move it to our repository so that we could quickly fix and improve the generator.

I'm just continuing the work of @andriy-dmytruk . He's working on other projects now.

In other words: yes, he knows :-)

@wing328
Copy link
Member

wing328 commented Nov 16, 2024

thanks for the details. we will follow the typical procedure to deprecate the generator.

have a nice weekend

@altro3
Copy link
Contributor Author

altro3 commented Nov 16, 2024

Regarding the official one: once again, the micronaut repository contains the same generator, it's just that all the improvements to it are made in the micronaut-openapi repository. I told you the reason above. The generator that is here hasn't been supported for over a year.

There is screenshot from micronaut-openapi repo:

{D00C937D-A708-473E-ABD9-4687BB5E13B5}

@altro3
Copy link
Contributor Author

altro3 commented Nov 16, 2024

@andriy-dmytruk
Copy link
Contributor

andriy-dmytruk commented Nov 16, 2024

Yes, I confirm this looks good. Historically, we moved the generator to Micronaut repo when Micronaut 3.x was released in order to make it simpler to make changes to it, control what is merged and integrate with micronaut maven and gradle plugins better. That implementation is still based on this generator.

The generator in this repo is for Micronaut 2.x and it isn't really maintained, so it makes sense to deprecate it to me.

Thanks @altro3

@wing328
Copy link
Member

wing328 commented Nov 18, 2024

OK. I'll work on this PR and get it merged by the end of this week.

@wing328 wing328 merged commit cdafa5a into OpenAPITools:master Nov 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants