-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][PYTHON] fix setup.py when no paths are specified #20098
[BUG][PYTHON] fix setup.py when no paths are specified #20098
Conversation
2020d96
to
76317df
Compare
thanks for the PR. please follow step 3 to update the samples |
76317df
to
e3200c1
Compare
Done ;) |
e3200c1
to
d5b1146
Compare
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
d75bfb9
to
8f21e91
Compare
8f21e91
to
d582a6c
Compare
done |
@loic-seguin can you please review the build failure when you've time? |
will do |
Hello, hmmm I rebased and I did these steps :
And I get => 289 passed, 3 skipped, 18 warnings in 9.83s. And the tests that were not passing on the CI are apparently passing on my local now. |
trigger tests via #20339 instead let's see how that goes |
all tests passed. tested locally and found the following diff against the master: diff --git a/setup.py b/setup.py
index 22a42d0..e56366b 100644
--- a/setup.py
+++ b/setup.py
@@ -23,27 +23,3 @@ from setuptools import setup, find_packages # noqa: H301
NAME = "openapi-client"
VERSION = "1.0.0"
PYTHON_REQUIRES = ">= 3.8"
-REQUIRES = [
- "urllib3 >= 1.25.3, < 3.0.0",
- "python-dateutil >= 2.8.2",
- "pydantic >= 2",
- "typing-extensions >= 4.7.1",
-]
-
-setup(
- name=NAME,
- version=VERSION,
- description="Example Hello API",
- author="OpenAPI Generator community",
- author_email="[email protected]",
- url="",
- keywords=["OpenAPI", "OpenAPI-Generator", "Example Hello API"],
- install_requires=REQUIRES,
- packages=find_packages(exclude=["test", "tests"]),
- include_package_data=True,
- long_description_content_type='text/markdown',
- long_description="""\
- No description provided (generated by Openapi Generator https://github.com/openapitools/openapi-generator)
- """, # noqa: E501
- package_data={"openapi_client": ["py.typed"]},
-)
\ No newline at end of file
which confirms the fix thanks again for the PR |
This PR is related to this issue #20090.
Looping on {{#apis}} in the setup.mustache is not needed I think because we already have the infos at the root level.
As a consequence the setup method is always present if no paths attribute is given inside the yaml.
TODO : We might need to do this also for the generator python-pydantic-v1...
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)