Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] Add missing dependencies in templates #20075

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

DielN
Copy link
Contributor

@DielN DielN commented Nov 9, 2024

Fixes #20073

  • Add commons-lang3 dependency for libraries supporting useReflectionEqualsHashCode
  • Add mutiny dependency for microprofile 3.0 pom
  • maybe find other missing dependencies for certain configs -> deferred

I can't really test the sbt files since I'm not familiar with that, gradle maybe. Not sure if the CI tests those or only uses maven?

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@DielN
Copy link
Contributor Author

DielN commented Nov 10, 2024

The feign-no-nullable generated samples contain some swagger stuff which causes errors for me. But this is not caused by me, since even on the latest master this happens. The sample has just never been in the CI. I added it since I added the useReflectionEqualsHashCode to it.

Is this caused by some manual samples? If I delete the directory and completely regenerate it, those files are not there.
It also works if I add swagger1AnnotationLibrary: true to the config AND add the imports for the annotations to the model template because those are missing in the generated models (probably a bug).
What's the right approach to handle this? Just remove the swagger annotations from those files? Whatever those manual samples test, I don't think the annotations are needed for that.

It works if I set it to swagger1 (annotationLibrary: "swagger1"). Used the wrong property before.
Is that the correct way to fix this?

@wing328
Copy link
Member

wing328 commented Nov 10, 2024

It works if I set it to swagger1 (annotationLibrary: "swagger1"). Used the wrong property before.
Is that the correct way to fix this?

please go ahead with this way for the time being

@wing328
Copy link
Member

wing328 commented Nov 12, 2024

@DielN thanks for the PR. Is this PR ready for review?

We will release v7.10.0 soon so wondering if we can include this one.

@DielN DielN marked this pull request as ready for review November 13, 2024 02:44
@DielN
Copy link
Contributor Author

DielN commented Nov 13, 2024

There are quite some more dependencies which are missing in the poms and especially the gradle / sbt files (e.g. hibernate validator), but I'm not sure when I'll find time for it so let's just merge this one & I'll do the others separately if/when I find time

@DielN
Copy link
Contributor Author

DielN commented Nov 13, 2024

forgot to mention the people for review :)
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Member

wing328 commented Nov 14, 2024

and especially the gradle / sbt files (e.g. hibernate validator),

agreed we can deal with that later and see if others in the community can help out with this.

@wing328 wing328 merged commit 216ba30 into OpenAPITools:master Nov 14, 2024
87 checks passed
@wing328 wing328 added this to the 7.10.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] Dependencies missing for some Java libraries / configs
2 participants