-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAVA] Add missing dependencies in templates #20075
[JAVA] Add missing dependencies in templates #20075
Conversation
The feign-no-nullable generated samples contain some swagger stuff which causes errors for me. But this is not caused by me, since even on the latest master this happens. The sample has just never been in the CI. I added it since I added the Is this caused by some manual samples? If I delete the directory and completely regenerate it, those files are not there. |
please go ahead with this way for the time being |
@DielN thanks for the PR. Is this PR ready for review? We will release v7.10.0 soon so wondering if we can include this one. |
There are quite some more dependencies which are missing in the poms and especially the gradle / sbt files (e.g. hibernate validator), but I'm not sure when I'll find time for it so let's just merge this one & I'll do the others separately if/when I find time |
forgot to mention the people for review :) |
agreed we can deal with that later and see if others in the community can help out with this. |
Fixes #20073
useReflectionEqualsHashCode
I can't really test the sbt files since I'm not familiar with that, gradle maybe. Not sure if the CI tests those or only uses maven?
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)