-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala Cask oneOf support #20051
Scala Cask oneOf support #20051
Conversation
1cb59a8
to
433a809
Compare
also updated libs and an 'errors' field rename to address name clashes with likely/popular field names
433a809
to
2a7944e
Compare
As ever, thanks again @wing328 in advance for your time on these PRs. In this case, I look to be getting a spurious Typescript failure ... not sure how to address that? |
please ignore that for the time being |
Ok - thanks. Are merges paused until that's resolved, or can we merge into a broken build for other generators? |
thanks for the PR please update https://github.com/OpenAPITools/openapi-generator/blob/master/bin/configs/scala-cask-petstore.yaml with a new |
Includes a oneOf and allOf example
Excellent shout! Many thanks ... done 👍 |
nice. let's give it a try |
CI failure fixed via 85f7112 |
William, you are an absolute star!
…On Mon, Nov 11, 2024 at 11:01 AM William Cheng ***@***.***> wrote:
CI failure fixed via 85f7112
<85f7112>
—
Reply to this email directly, view it on GitHub
<#20051 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMIOPNFQH2CC6XYDOSP2L2ACE65AVCNFSM6AAAAABRLCABIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRXHA4TAOBUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Scala Cask: This PR adds support for using union-types for oneOf requests.
It also updates some scala libraries in the SBT build and addresses a potential name conflict in the generated
code ('errors' has been renamed).
Local regressions tests have been added to cover these cases which are not part of this PR
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)