Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-fetch][Fix] oneOf models are generated without ...ToJSONTyped functions but models referencing still try to import #20046

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

guizmaii
Copy link
Contributor

@guizmaii guizmaii commented Nov 7, 2024

Fixes #19858

Bug introduced in #19524

@wing328 this is needed for 7.10.0 otherwise the typescript-fetch generator will be broken in this this release.

CC @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@guizmaii guizmaii changed the title Fix #19858 [typescript-fetch][Fix] oneOf models are generated without ...ToJSONTyped functions but models referencing still try to import Nov 7, 2024
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix.
please re-generate the samples

@guizmaii
Copy link
Contributor Author

guizmaii commented Nov 7, 2024

@macjohnny Done :)

@wing328
Copy link
Member

wing328 commented Nov 7, 2024

@guizmaii thanks for the PR and sorry for the regression.

I wonder if you can add a test or 2 in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/fetch/TypeScriptFetchClientCodegenTest.java to cover this issue moving forward.

@wing328 wing328 added this to the 7.10.0 milestone Nov 7, 2024
@macjohnny macjohnny merged commit 2c38d0d into OpenAPITools:master Nov 7, 2024
16 checks passed
@guizmaii guizmaii deleted the fix_19858 branch November 7, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants