-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test on Windows #19980
Fix test on Windows #19980
Conversation
Can we find an execution that works for both windows and *nix or add an if/else in the test for the system instead of commenting it out? |
I don't expect to troubleshoot this anytime soon but if you want to send a pr ill tell you if it works for me. Otherwise we should comment it out until we fix it. Also, maybe there should be a pr gate that runs the tests on windows. |
Can you execute the commands behind call 2 and 3 on Windows and let me know what they yield, please? I do not have access to Windows unfortunately. Agree with the CI step on Windows. I was under the impression this is something we do already. |
Is there no |
We do have workflow to test on windows: https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/windows.yaml
|
I fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Fixes #19924
@joscha Pinging author of these tests for awareness
Here are the logs produced by ./mvnw clean package
[ERROR] Failures:
[ERROR] org.openapitools.codegen.DefaultCodegenTest.testExecutePostProcessor
[ERROR] Run 1: DefaultCodegenTest.testExecutePostProcessor:755 expected [true] but found [false]
[ERROR] Run 2: DefaultCodegenTest.testExecutePostProcessor:755 expected [true] but found [false]
[ERROR] Run 3: DefaultCodegenTest.testExecutePostProcessor:755 expected [true] but found [false]
[INFO]
[INFO]
[ERROR] Tests run: 3214, Failures: 1, Errors: 0, Skipped: 4
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)