Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA]: Fix unknown property error for gradle build #19933

Merged

Conversation

HeneryHawk
Copy link
Contributor

If i generate a client for java with the library native, i get the following error when i try to build the client via ./gradlew assemble.

/build.gradle' line: 53
Could not set unknown property 'classifier' for task ':sourcesJar' of type org.gradle.api.tasks.bundling.Jar.

This error can also be reproduced if you use the native Java echo_api client sample.
According to the gradle documentation, the classifier property was removed with the update to Gradle 8.x
See: https://docs.gradle.org/current/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup

@bbdouglas @Zomzog @lwlee2608 @martin-mfg

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@martin-mfg
Copy link
Contributor

Hi @HeneryHawk, thanks for the PR!

May I ask you to apply the same fix for other Java libraries besides native as well?

@HeneryHawk
Copy link
Contributor Author

Hi @martin-mfg

yes I can do that but can we postpone this to a later PR? We would need the adaptions for native asap...

Regards

@wing328
Copy link
Member

wing328 commented Oct 23, 2024

@HeneryHawk thanks for the PR.

totally ok to have a separate PR to address similar issue in other build.gradle files.

i'm able to repeat the issue by adding gradle build tests for java native petstore samples via #19951

will get that one merged after merging your fix so that this issue is covered moving forward.

@wing328 wing328 added this to the 7.10.0 milestone Oct 23, 2024
@wing328 wing328 merged commit 21093b7 into OpenAPITools:master Oct 23, 2024
77 checks passed
@wing328
Copy link
Member

wing328 commented Oct 23, 2024

UPDATE: merged #19951 to add tests and sync pom.xml & build.gradle (to fix an issue when useJakartaEe is eanbled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants