Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp][generichost] Better handling of duplicate operation ids #19913

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Oct 19, 2024

Reverts a part of #19715 and handles the duplicate operation id better.

Fixes #19686
Fixes #19865

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@devhl-labs devhl-labs mentioned this pull request Oct 19, 2024
5 tasks
@wing328
Copy link
Member

wing328 commented Oct 30, 2024

can you please resolve the merge conflicts when you've time? then i'll merge and also later add a test to cover this via a separate PR

@devhl-labs
Copy link
Contributor Author

done

@wing328 wing328 merged commit 54920ff into OpenAPITools:master Nov 6, 2024
28 checks passed
@wing328 wing328 added this to the 7.10.0 milestone Nov 6, 2024
@devhl-labs devhl-labs deleted the 19708-better-handling-of-duplicate-operation-ids branch November 6, 2024 13:32
@wing328
Copy link
Member

wing328 commented Nov 9, 2024

FYI: merged #20070 to add testS covering duplicated operationId moving forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants