Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scala][client]: scala-http4s: minor improvement (enum companion method, remove implicit, error handling) #19901

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

JennyLeahy
Copy link
Contributor

@JennyLeahy JennyLeahy commented Oct 17, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@JennyLeahy
Copy link
Contributor Author

@wing328
Copy link
Member

wing328 commented Nov 6, 2024

thanks again for the PR and took my feedback

from what I know, there's no breaking change in this PR so I'll merge it later this week

thanks for the contribution.

@wing328 wing328 merged commit 961c2e4 into OpenAPITools:master Nov 8, 2024
28 checks passed
@wing328
Copy link
Member

wing328 commented Nov 8, 2024

when you're free next week, can you please PM me to discuss the breaking change? thanks

i think i may find a way to incorporate it in the upcoming minor release (which allows breaking changes with fallback)

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@JennyLeahy
Copy link
Contributor Author

@wing328 sorry, I missed the invitation. Could you send me the invite again? Thanks a lot

@wing328
Copy link
Member

wing328 commented Nov 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants