Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] Address obsolete build warnings in ApiClient #19847

Merged

Conversation

alec-petersen
Copy link
Contributor

@alec-petersen alec-petersen commented Oct 11, 2024

See issue #19525

  • Non-async overload of Deserialize is obsolete, RestSharp suggests using async overload of Deserialize instead.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@alec-petersen alec-petersen marked this pull request as ready for review October 11, 2024 12:24
@alec-petersen
Copy link
Contributor Author

@wing328
Copy link
Member

wing328 commented Oct 12, 2024

@alec-petersen
Copy link
Contributor Author

alec-petersen commented Oct 13, 2024

@wing328 Undid the timeout change, moved it to #19854

@wing328
Copy link
Member

wing328 commented Oct 14, 2024

@wing328 wing328 closed this Oct 14, 2024
@wing328 wing328 reopened this Oct 14, 2024
@wing328 wing328 merged commit b5b760a into OpenAPITools:master Oct 14, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants