-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAVA] fix several anyOf/oneOf problems #19817
Conversation
please update the samples when you've time overall the change looks good. will merge after all tests pass thank you |
@wing328 done :) |
looks good. thank you. |
can you please correct the same issue in
? |
We upgraded from version 7.6.0 to 7.10.0 and found that changes between these versions break the java-camel generator's processing of the oneOf/anyOf definitions. For example, the following schema generates proper code with version 7.6.0, but the generator version 7.10.0 creates a class with no fields. We are using version 3.0.3 of the OpenAPI spec.
|
Hi @kulon, I wasn't able to reproduce your problem yet. Could you please share the full openAPI spec and generator settings? |
HI @martin-mfg, please take a look at this sample app: Just changing the generator's version in the pom.xml from 7.6.0 to 7.10.0 will break the app. |
The problem occurs already in OpenAPI Generator version 7.9.0, according to my tests. i.e. it is not caused by this PR. Please open a new issue for your problem (assuming no similar issue has been opened yet). |
Created a bug report #20312 |
Fix various problems when using anyOf or oneOf. Mostly focusing on the Jersey libraries.
I separated the fixed problems into different commits in this PR:
e.g. in samples/client/petstore/java/okhttp-gson/src/main/java/org/openapitools/client/model/FakeAnyOfWIthSameErasureGet200Response.java we now also generate the method "getListInteger". Previously this was skipped due to "getListString" already being created.
The mustache file changes also include a small simplification of the relevant template part. The Jersey anyOf*.mustache templates were a bit out of sync and needed to be aligned with their oneOf counterparts - see here for context.
useBeanValidation=true
, don't generate uncompilable code.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)