Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java rest client ApiClient template to properly assign ObjectMapper #19795

Conversation

CaptainAye
Copy link
Contributor

Description:
The changes fix the ApiClient mustache template for java RestClient generator. Some of the constructors didn't properly pass the ObjectMapper parameter on, leading to creating default mapper even if the consumer passed custom instance.
Additionally, PR refactors the ApiClient constructors in order to move the creation logic to the one, most specific, constructor.

The pr fixes #19667

Technical committee Java:
@martin-mfg, @lwlee2608, @Zomzog, @karismann, @jeff9finger, @cbornet, @lukoyanov, @jfiala, @sreeshas, @bbdouglas

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Oct 7, 2024

thanks for the PR

please follow step 3 to update the samples so that the CI can test the change properly

@wing328 wing328 added this to the 7.9.0 milestone Oct 7, 2024
@CaptainAye CaptainAye force-pushed the 19667-assign-proper-object-mapper-rest-client-api-client branch from ef8fe30 to 71eaa08 Compare October 7, 2024 07:37
@CaptainAye
Copy link
Contributor Author

thanks for the PR

please follow step 3 to update the samples so that the CI can test the change properly

I added all the generated changes to the pr.

@wing328
Copy link
Member

wing328 commented Oct 7, 2024

thanks again for the PR

did you test the fix locally to confirm it addresses the issue mentioned in the PR?

@CaptainAye
Copy link
Contributor Author

thanks again for the PR

did you test the fix locally to confirm it addresses the issue mentioned in the PR?

Yes, I verified that the ObjectMapper is being properly passed to the ApiClient from any constructor, which was not the case previously.
I am happy to add some unit tests as well if it's required.

@wing328 wing328 merged commit a82475e into OpenAPITools:master Oct 8, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [java][restclient] ObjectMapper passt to ApiClient is ignored
2 participants