-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java][resttemplate] Fix model combining properties and additional properties #19706
base: master
Are you sure you want to change the base?
Conversation
d93b9e4
to
ea0fd25
Compare
Hi @JoaoBrlt, thanks for the PRs! They look really good. 👍 |
Hey @martin-mfg! 👋 Thanks for approving the pull requests. Yeah, no problem. I'll take a look right now. |
Hey @martin-mfg! I updated the pull requests to resolve the conflicts with the |
Hey @martin-mfg @wing328! 👋 Do you think we could merge these pull requests for the next version? This would be very useful for my current project. Indeed, we have to manually patch the OpenAPI specs to fix the code generation. I would be happy to help if needed. 😄 |
just for your info: I've done everything I could by approving your PR. :) Now it's up to @wing328 to merge it, because I don't have merge permissions. |
Hi @wing328 ! 👋 I just rebased the branch to avoid conflicts. Do you think we could merge this pull request? It should be a quick win and it would be very useful for my current project. |
@JoaoBrlt thanks for the PR please ping me via Slack for a quick chat when you've time: https://join.slack.com/t/openapi-generator/shared_invite/zt-2uoef5v0g-XGwo8~2oJ3EoziDSO1CmdQ |
When
additionalProperties
is set totrue
, use anadditionalProperties
attribute and@JsonAnySetter
and@JsonAnyGetter
annotations instead of extendingHashMap
.This fixes the issue #17361 only for the
resttemplate
library.I also created the following pull requests to fix the same issue for other libraries:
webclient
library.feign
library.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) @wing328