-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][Java] Fixed jersey clients for multiple file upload #19476
[Bugfix][Java] Fixed jersey clients for multiple file upload #19476
Conversation
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
@@ -1034,6 +1020,28 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} { | |||
return entity; | |||
} | |||
|
|||
private void addParamToMultipart(Object value, String key, MultiPart multiPart) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestion: add a docstring explaining what this function does
thanks for the PR I wonder if you've time to fix the same issue in jersey2 ApiClient.java as well: modules/openapi-generator/src/main/resources/Java/libraries/jersey2/ApiClient.mustache |
Only if this fix comes in the next version ;) done |
Tested locally, haven't opened a Issue since the change required less effort and is small.
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)