Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Java] Fixed jersey clients for multiple file upload #19476

Conversation

MatteoMolinari93
Copy link
Contributor

Tested locally, haven't opened a Issue since the change required less effort and is small.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Aug 28, 2024

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@@ -1034,6 +1020,28 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} {
return entity;
}

private void addParamToMultipart(Object value, String key, MultiPart multiPart) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion: add a docstring explaining what this function does

@wing328
Copy link
Member

wing328 commented Aug 29, 2024

thanks for the PR

I wonder if you've time to fix the same issue in jersey2 ApiClient.java as well: modules/openapi-generator/src/main/resources/Java/libraries/jersey2/ApiClient.mustache

@MatteoMolinari93 MatteoMolinari93 changed the title [Bugfix][Java] Fixed jersey3 client for multiple file upload [Bugfix][Java] Fixed jersey clients for multiple file upload Aug 29, 2024
@MatteoMolinari93
Copy link
Contributor Author

thanks for the PR

I wonder if you've time to fix the same issue in jersey2 ApiClient.java as well: modules/openapi-generator/src/main/resources/Java/libraries/jersey2/ApiClient.mustache

Only if this fix comes in the next version ;) done

@wing328 wing328 added this to the 7.9.0 milestone Sep 2, 2024
@wing328 wing328 merged commit fb1c2f3 into OpenAPITools:master Sep 2, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants