-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: test with more modern versions #19452
Conversation
Releasing the Python version to >= 3.8 pulls in a newer version of aiohttp, which triggers this bug: aio-libs/aiohttp#8555 |
@@ -21,7 +21,7 @@ jobs: | |||
- uses: actions/checkout@v4 | |||
- uses: actions/setup-python@v5 | |||
with: | |||
python-version: '3.9' | |||
python-version: '3.12' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.9 is the minimal supported version. shall we keep it as it's to ensure changes won't break 3.9 support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this 3.9 or 3.8 actually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wing328 I used 3.8 instead of 3.7 ; I couldn't find the information whether the generator was supporting 3.8 or 3.9.
As I say in the first post, 3.8 will be out of support next month ; I'm happy to remove 3.8 in favor of 3.9 as well.
Python 3.12 has been released in October 2023, it should be tested in the CI. Python 3.7 is not maintained anymore, removing it from the minimum required version in `pyproject.toml` files.
bfa3701
to
6c96c19
Compare
cc @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10) |
@wing328 when you have time, could you check this out? |
just merged. thanks for the PR |
We can also wait until end of October and completely remove 3.8 then :D |
Usually we won't drop the support right away even though it has reached the EOL as some users may still be using it. |
pyproject.toml
files.Using Python > 3.7 to test the asyncio code also pulls in a new version of aiohttp which triggers this bug: aio-libs/aiohttp#8555. The tests have been adjusted to use aiohttp correctly now, and all the tests for asyncio-related samples have been regenerated accordingly.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)