Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerShell] Support multiple files in multipart/form-data POST (new functionality + fix) #19449

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

condorcorde
Copy link
Contributor

api.mustache was modified again in order to support the Dradis API that allows multiple files to be submitted in the same multipart/form-datarequest.

En passant, a required cast to System.IO.FileInfo that was lost in a ghost commit has been reintroduced.

Here are examples of requests generated during the tests of this PR, with one and two files:

$ New-DRDAttachment -DradisProjectId 166 -NodeId 4440 -Files a.png

POST /pro/api/nodes/4440/attachments HTTP/2
[...]
Content-Type: multipart/form-data; boundary="fcf39142-ebb8-46c1-9dda-1827e6685617"
Content-Length: 650

--fcf39142-ebb8-46c1-9dda-1827e6685617
Content-Disposition: form-data; name="files[]"; filename=a.png; filename*=utf-8''a.png
Content-Type: application/octet-stream

�PNG
[...]
--fcf39142-ebb8-46c1-9dda-1827e6685617--
$ New-DRDAttachment -DradisProjectId 166 -NodeId 4440 -Files a.png,b.png

POST /pro/api/nodes/4440/attachments HTTP/2
[...]
Content-Type: multipart/form-data; boundary="c5d81892-2bec-4150-b31a-c638e0f0eb19"
Content-Length: 1279

--c5d81892-2bec-4150-b31a-c638e0f0eb19
Content-Disposition: form-data; name="files[]"; filename=a.png; filename*=utf-8''a.png
Content-Type: application/octet-stream

�PNG
[...]
--c5d81892-2bec-4150-b31a-c638e0f0eb19
Content-Disposition: form-data; name="files[]"; filename=b.png; filename*=utf-8''b.png
Content-Type: application/octet-stream

�PNG
[...]
--c5d81892-2bec-4150-b31a-c638e0f0eb19--

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @wing328

@wing328
Copy link
Member

wing328 commented Aug 26, 2024

@wing328 wing328 merged commit fe381e2 into OpenAPITools:master Aug 26, 2024
31 checks passed
@condorcorde condorcorde deleted the support-multiple-files branch August 27, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants