Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust Server] Use swagger/multipart_related support #19354

Merged

Conversation

richardwhiuk
Copy link
Contributor

@richardwhiuk richardwhiuk commented Aug 14, 2024

Use functions from the https://github.com/Metaswitch/swagger-rs crate for multipart/related helper functions, rather than including the logic in every generated crate.

This updates the generated code to use functions from the swagger-rs crate, rather than having hand rolled code in each crate. Code in the support crate is easier to test, update and bug fix, rather than generated code which requires each generated crate to be updated.

Support was added in 5.0 - the generated code already uses the swagger-rs 6

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Rust Technical Committee: @frol @farcaller @paladinzh @jacob-pro

@richardwhiuk richardwhiuk added Server: Rust Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. rust labels Aug 14, 2024
@wing328 wing328 merged commit be09f8a into OpenAPITools:master Aug 15, 2024
19 checks passed
@wing328 wing328 added this to the 7.8.0 milestone Aug 15, 2024
@richardwhiuk richardwhiuk deleted the rust-server-swagger-multipart-related branch August 15, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Server: Rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants